[IR] Platform-independent SHash#14204
Merged
tqchen merged 1 commit intoapache:mainfrom Mar 7, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tqchen
reviewed
Mar 6, 2023
junrushao
force-pushed
the
feature/2023-03-05/stable-shash
branch
from
1be81e5 to
94144b9
Compare
Member
Author
|
@tqchen please take another look :-) |
Hzfengsy
approved these changes
Mar 6, 2023
tqchen
reviewed
Mar 6, 2023
This PR introduces the necessary change to make structural-hash platform-independent. The change includes: - Explicitly require the hash type to be `uint64_t` rather than platform-dependent `size_t`. - Implement structural hash for POD types including `double`, `int` by unioning them with `uint64_t` explicitly. - Implement a platform-independent fast hashing algorithm for `std::string`
junrushao
force-pushed
the
feature/2023-03-05/stable-shash
branch
from
94144b9 to
e2a46ae
Compare
Member
Author
|
@tqchen please take another look! |
tqchen
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the necessary change to make structural-hash platform-independent. The change includes:
uint64_trather than platform-dependentsize_t.double,intby unioning them withuint64_texplicitly.std::string