[TIR][Compute-at] Utilize InverseAffineIterMap for dom estimation#14184
Merged
wrongtest-intellif merged 1 commit intoapache:mainfrom Mar 16, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
approved these changes
Mar 3, 2023
yzh119
approved these changes
Mar 7, 2023
Member
yzh119
left a comment
There was a problem hiding this comment.
Thank you @wrongtest-intellif for the PR, it helps addresses some of the issues we met when tensorize workloads with mma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
compute-atprimitive currently, when estimate iteration domain to cover required buffer region, we use limited heuristic rules. The change try to improve using existing arith toolInverseAffineIterMap. Then theoretically, all single buffer access which is of bijective mapping from block iter vars are solvable.A new test case describe that if a block represents arbitary transpose/reshape ops,
compute-atthis block would always expect to success.Also fix one issue when the iter scale is -1.