[WEB] WebGPU Codegen#14048
Merged
junrushao merged 1 commit intoapache:mainfrom Feb 20, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
reviewed
Feb 20, 2023
| int bits = arg.dtype().bits(); | ||
| PrimExpr res; | ||
| if (arg.dtype().is_float() && (bits == 16 || bits == 32)) { | ||
| res = topi::fast_erf_float_expr(arg, bits); |
Member
There was a problem hiding this comment.
i know it's from some legacy impl of metal, but can we structure the folder slightly better to avoid depending on topi? i.e. moving this method to tir instead.
Member
Author
There was a problem hiding this comment.
Thanks for the comment, reorganized to remove topi dep
This PR provide an implementation of WebGPU codegen. Previously we relied on SPIRV codegen for WebGPU, which is deprecated in favor of the WGSL shading language. Pass limited testing on elementwise via chrome. Likely we will do future iterations. Also cleans up some legacy code organization in intrinsics.
yongwww
pushed a commit
to yongwww/tvm
that referenced
this pull request
Feb 27, 2023
This PR provide an implementation of WebGPU codegen. Previously we relied on SPIRV codegen for WebGPU, which is deprecated in favor of the WGSL shading language. Pass limited testing on elementwise via chrome. Likely we will do future iterations. Also cleans up some legacy code organization in intrinsics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provide an implementation of WebGPU codegen. Previously we relied on SPIRV codegen for WebGPU, which is deprecated in favor of the WGSL shading language. Pass limited testing on elementwise via chrome.
Likely we will do future iterations.