[TIR] [Bugfix] Pass the correct block_sref_reuse to Replace#14023
Merged
tqchen merged 3 commits intoapache:mainfrom Feb 18, 2023
Merged
[TIR] [Bugfix] Pass the correct block_sref_reuse to Replace#14023tqchen merged 3 commits intoapache:mainfrom
tqchen merged 3 commits intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
A mismatch between the blocks present in the `result` vs the blocks passed in `block_sref_to_reuse` caused the bug mentioned in apache#13974. This patch tries to fix that bug by collecting only the blocks that are part of result and also present in the block replacement map `new_block_to_old_`. Since the scope block is `result`, only that block and its child blocks would be replaced, and any replaced block would be present in `rewriter.new_block_to_old_`. Thus, collecting the replaced blocks from among child blocks of `result` guarantees that the `block_sref_reuse` would contain all the replaced blocks and that they'll point to the correct block in `result` thus avoiding the missing SRef error.
quic-sanirudh
force-pushed
the
layout_transform_sref_bug
branch
from
fbb30f0 to
832ffdc
Compare
Hzfengsy
reviewed
Feb 17, 2023
Member
Hzfengsy
left a comment
Hzfengsy
left a comment
There was a problem hiding this comment.
Please add a regression test for it
Contributor
Author
Yes, I realized that I did not add the test after creating the PR. I'll update with the test, thanks. |
yongwww
pushed a commit
to yongwww/tvm
that referenced
this pull request
Feb 27, 2023
…4023) * [TIR] [Bugfix] Pass the correct block_sref_reuse to Replace A mismatch between the blocks present in the `result` vs the blocks passed in `block_sref_to_reuse` caused the bug mentioned in apache#13974. This patch tries to fix that bug by collecting only the blocks that are part of result and also present in the block replacement map `new_block_to_old_`. Since the scope block is `result`, only that block and its child blocks would be replaced, and any replaced block would be present in `rewriter.new_block_to_old_`. Thus, collecting the replaced blocks from among child blocks of `result` guarantees that the `block_sref_reuse` would contain all the replaced blocks and that they'll point to the correct block in `result` thus avoiding the missing SRef error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mismatch between the blocks present in the
resultvs the blocks passed inblock_sref_to_reusecaused the bug mentioned in #13974.This patch tries to fix that bug by collecting only the blocks that are part of result and also present in the block replacement map
new_block_to_old_. Since the scope block isresult, only that block and its child blocks would be replaced, and any replaced block would be present inrewriter.new_block_to_old_. Thus, collecting the replaced blocks from among child blocks ofresultguarantees that theblock_sref_reusewould contain all the replaced blocks and that they'll point to the correct block inresultthus avoiding the missing SRef error.