[CLML] Changes corresponding to OpenCL workspace refactorization#13972
Merged
echuraev merged 3 commits intoapache:mainfrom Feb 16, 2023
Merged
[CLML] Changes corresponding to OpenCL workspace refactorization#13972echuraev merged 3 commits intoapache:mainfrom
echuraev merged 3 commits intoapache:mainfrom
Conversation
OpenCL context accessing is changed while refactoring OpenCL backend.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
echuraev
reviewed
Feb 14, 2023
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
Sorry, I forgot to update OpenCLML part in the PR with OpenCL workspace refactoring. Thank you for the PR.
srkreddy1238
force-pushed
the
latest_main
branch
from
9011963 to
5d978f5
Compare
echuraev
approved these changes
Feb 15, 2023
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
In general LGTM. One question and after the answer or adding some changes (up to you, I'm ok with current version of code) it can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCL context accessing is changed while refactoring OpenCL backend.