[TVMScript] Encourage using T.Buffer directly#13971
Merged
cyx-6 merged 1 commit intoapache:mainfrom Feb 13, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
junrushao
force-pushed
the
feature/2023-02-12/buffer_decl_to_buffer
branch
from
1138796 to
f5b338b
Compare
Member
Author
|
CC: @cyx-6 |
junrushao
force-pushed
the
feature/2023-02-12/buffer_decl_to_buffer
branch
from
f5b338b to
efe5cec
Compare
Previously there are two equivalent ways of declaring a buffer in TVMScript: ```python buffer = T.buffer_decl(...) buffer = T.Buffer(...) ``` The two approaches are aliases to each other and are essentially the same in implementation. Therefore, this PR encourages to use `T.Buffer` as the recommended approach as it's a bit shorter. Meanwhile, `T.buffer_decl` will continue to be valid in TVMScript, but a deprecation warning will be emitted if its used.
junrushao
force-pushed
the
feature/2023-02-12/buffer_decl_to_buffer
branch
from
efe5cec to
48adf3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there are two equivalent ways of declaring a buffer in TVMScript:
The two approaches are aliases to each other and are essentially the same in implementation. Therefore, this PR encourages to use
T.Bufferas the recommended approach as it's a bit shorter. Meanwhile,T.buffer_declwill continue to be valid in TVMScript, but a deprecation warning will be emitted if its used.