[TVMScript] Enable Safe Autocasting in BufferStore#13960
Merged
tqchen merged 1 commit intoapache:mainfrom Feb 12, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
junrushao
force-pushed
the
feature/2023-02-11/buffer-store-dtype
branch
4 times, most recently
from
d3a51c4 to
da1ebd5
Compare
MasterJH5574
approved these changes
Feb 12, 2023
Hzfengsy
approved these changes
Feb 12, 2023
Member
Hzfengsy
left a comment
Hzfengsy
left a comment
There was a problem hiding this comment.
Please update the PR description and we can get it in
Member
Author
|
I will tweak it a bit by adding some more warning messages today and ping you guys back tomorrow |
Previously, when writing a BufferStore statement in TVMScript, dtype mismatch will not be detected but silently allowed. For example, in the snippet below: ```python buffer[indices] = RHS ``` even if the elements of `buffer` is floating point numbers, while RHS is a handle, there is no mechanism to warn, fix, or error out. This PR introduces auto casting mechanism in TVMScript to ensure that the dtype of RHS matches LHS. When there is possible precision loss, it will emit a warning so that the users could adjust accordingly.
junrushao
force-pushed
the
feature/2023-02-11/buffer-store-dtype
branch
from
4c103f4 to
9d1c070
Compare
junrushao
changed the title
Member
Author
|
@Hzfengsy @MasterJH5574 I added an extra warning when there is potential precision loss, for example, casting floating point numbers to integers. It should be good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when writing a BufferStore statement in TVMScript, dtype
mismatch will not be detected but silently allowed.
For example, in the snippet below:
even if the elements of
bufferis floating point numbers, while RHSis a handle, there is no mechanism to warn, fix, or error out.
This PR introduces auto casting mechanism in TVMScript to ensure that
the dtype of RHS matches LHS. When there is possible precision loss, it
will emit a warning so that the users could adjust accordingly.