[TensorRT] Fix BiasAdd with correct axis attribute#13953
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
added 2 commits
February 10, 2023 20:59
Author
|
Thanks @yongwww ! Can you merge this PR? It passed the CI. |
masahi
approved these changes
Feb 11, 2023
ghost
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 13, 2023
* [TensorRT] Fix BiasAdd with correct axis attribute * lint * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original TensorRT BiasAdd converter does not use
axisattribute fromnn.bias_addso it only works withNC, NCHWand implicit mode (when batch dimension is removed).We recently found some NLP and Vision Transformer models are parsed with
axis=-1which caused reshape error later during conversion.This CR adds support of
axisattribute during conversion and related test case foraxis=-1