[microNPU] Merge LUT activation with binary elementwise operation#13935
Merged
lhutton1 merged 1 commit intoapache:mainfrom Feb 9, 2023
Merged
Conversation
Add binary elementwise operator to OptimizeLUTs pass to merge LUT activation with elementwise operation.
Collaborator
lhutton1
approved these changes
Feb 9, 2023
Contributor
lhutton1
left a comment
There was a problem hiding this comment.
Thanks @alexey-yazev, looks sensible to me, I just had a small nit from a previous issue with constant data types that should now be fixed
ekalda
approved these changes
Feb 9, 2023
Contributor
ekalda
left a comment
There was a problem hiding this comment.
Thanks @alexey-yazev, LGTM! When I initially implemented the LUT support, there was some binary elementwise issue I couldn't figure out, I suppose your previous fixes to binary elementwise have also removed that underlying issue... Great to see this fixed!
Contributor
|
Thanks @alexey-yazev, @ekalda! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add binary elementwise operator to OptimizeLUTs pass to merge LUT activation with elementwise operation. This PR is preparation for implementation of SoftMax operation.
cc @leandron, @ekalda, @lhutton1