[TVMScript,Fix] Fix findsource when classes are indented#13924
Merged
cyx-6 merged 1 commit intoapache:mainfrom Feb 7, 2023
Merged
[TVMScript,Fix] Fix findsource when classes are indented#13924cyx-6 merged 1 commit intoapache:mainfrom
cyx-6 merged 1 commit intoapache:mainfrom
Conversation
Leaving class definitions was not correctly handled when recreating scoping information. The fix correctly pops scope whenever the indentation level becomes less than the current scope.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tkonolige
force-pushed
the
fix_findsource
branch
from
c886856 to
4225528
Compare
cyx-6
approved these changes
Feb 7, 2023
Contributor
cyx-6
left a comment
cyx-6
left a comment
There was a problem hiding this comment.
Hi @tkonolige! Thanks for reporting this bug. The fix looks good to me.
cyx-6
pushed a commit
to cyx-6/tvm
that referenced
this pull request
Aug 22, 2023
This PR fixes the bug in parser source inspection. In apache#13924, we fixed the bug of nesting function by checking the indent decrease. However, we should skip the cases when the decrease is in the formatted multi-line function argument list. So this PR fixes this bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving class definitions was not correctly handled when recreating scoping information. The fix correctly pops scope whenever the indentation level becomes less than the current scope. I believe this was introduced in #12978.
@cyx-6 @junrushao