Fix build platform environment variable#13914
Merged
asparkhi merged 3 commits intoapache:mainfrom Feb 7, 2023
Merged
Conversation
Certain tests that make use of `pytest_wrapper.py`, such as those triggered by `task_python_integration.sh` will fail when a "PLATFORM" environment variable is not set within the Docker container. When using `build.sh` to both create a container, and run a command to execute one of the tests that requires a "PLATFORM", an error will occur due to the missing environment variable. This patch is necessary to add support for this environment variable to `build.sh` and prevent such errors.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
driazati
approved these changes
Feb 3, 2023
Contributor
Author
|
@tvm-bot rerun |
Contributor
Author
|
Seems to be a transient error with the CI locating Ubuntu mirrors. Was able to reproduce locally and now the issue has cleared up for me locally, so I will re-run the CI. |
Contributor
Author
|
@tvm-bot rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain tests that make use of
pytest_wrapper.py, such as those triggered bytask_python_integration.shwill fail when a "PLATFORM" environment variable is not set within the Docker container.When using
build.shto both create a container, and run a command to execute one of the tests that requires a "PLATFORM", an error will occur due to the missing environment variable.This patch is necessary to add support for this environment variable to
build.shand prevent such errors.CC @ashutosh-arm @leandron @Mousius @driazati @areusch