Revert the changes for NNPACK build issue#13913
Merged
driazati merged 6 commits intoapache:mainfrom Feb 7, 2023
Merged
Conversation
This patch undoes the change that was put in place to prevent the build and installation of NNPACK from failing due to a renaming of the default branch to main by the NNPACK external dependency cpuinfo. See apache#13871 The issue has been fixed at the source by PR apache#214, so the change to `ubuntu_install_nnpack.sh` is no longer required: Maratyszcza/NNPACK#214
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
asparkhi
reviewed
Feb 3, 2023
Contributor
Author
|
@tvm-bot rerun |
Contributor
Author
|
Seems to be a transient error with the CI locating Ubuntu mirrors. Was able to reproduce locally and now the issue has cleared up for me locally, so I will re-run the CI. |
Contributor
Author
|
@tvm-bot rerun |
driazati
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch undoes the change that was put in place to prevent the build and installation of NNPACK from failing due to a renaming of the default branch to main by the NNPACK external dependency cpuinfo.
See #13871
The issue has been fixed at the source by PR #214 which is now merged in to NNPACK, so the change to
ubuntu_install_nnpack.shis no longer required:Maratyszcza/NNPACK#214
CC @ashutosh-arm @leandron @driazati @areusch