[TIR][TOPI][CI] Fix number of arguments in calls of llvm_pure_intrin#13881
Merged
masahi merged 1 commit intoapache:mainfrom Jan 31, 2023
Merged
[TIR][TOPI][CI] Fix number of arguments in calls of llvm_pure_intrin#13881masahi merged 1 commit intoapache:mainfrom
masahi merged 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
@tvm-bot rerun |
Member
vinx13
approved these changes
Jan 31, 2023
masahi
approved these changes
Jan 31, 2023
Member
masahi
left a comment
masahi
left a comment
There was a problem hiding this comment.
yeah, I wondered why we were passing 0 to VNNI intrins and still getting correct output.
Member
|
@masahi I found that the number of args is used to decide the arg types of the intrin, if it is not overloaded, it doesn't matter |
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
…pache#13881) fix number of arguments in calls of llvm_pure_intrin Co-authored-by: Valery Chernov <valery.chernov@deelvin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All
call_llvm_pure_intrin(...)methods were rechecked and argument corresponding number of input args was corrected for some of them. Corresponding tests were upstreamed