[TVMScript] Connect assert_structural_equal with new TVMScript printer#13859
Merged
junrushao merged 1 commit intoapache:mainfrom Feb 5, 2023
Merged
[TVMScript] Connect assert_structural_equal with new TVMScript printer#13859junrushao merged 1 commit intoapache:mainfrom
assert_structural_equal with new TVMScript printer#13859junrushao merged 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
reviewed
Feb 1, 2023
Hzfengsy
approved these changes
Feb 2, 2023
add additional `ObjectPath` for body minor fix for `T.match_buffer` work in progress fallback printing for `Array` and `Map` more detailed `ObjectPath` from first mismatches add fallback for `Script` add comments of fallback mechanism fix grammar
Member
|
Thanks @cyx-6 for the PR! A side note: you may note the PR description in the commit message :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the output of
assert_structural_equal. Different from the directly printing mismatching nodes, in the old version, the improved one will print the whole scripts, with mismatching nodes underlined. And we print theObjectPathto the mismatching nodes for further better debug. For example, we have following functionsthe log of
assert_structural_equal(func1, func2)will be likeinstead of
which is not readable sometimes.