[TVMScript] Default to T.Buffer than T.buffer_decl#13838
Merged
junrushao merged 1 commit intoapache:mainfrom Jan 25, 2023
Merged
[TVMScript] Default to T.Buffer than T.buffer_decl#13838junrushao merged 1 commit intoapache:mainfrom
junrushao merged 1 commit intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
force-pushed
the
feature/2023-01-24/replace-buffer-decl
branch
3 times, most recently
from
d78bb00 to
41ac3e9
Compare
TVMScript parser supports both `T.Buffer` and `T.buffer_decl` interchangeably, which share the same semantics in TIR AST. However, `T.buffer_decl` is usually confused with `T.decl_buffer`. To clarify the semantics, we decide to print `T.Buffer` instead. Note that this PR is backward compatible with the previous behavior, i.e. the parser still parses TVMScript with `T.decl_buffer`, and the only difference is the print now produces `T.Buffer` instead by default.
junrushao
force-pushed
the
feature/2023-01-24/replace-buffer-decl
branch
from
41ac3e9 to
7fd9cd3
Compare
spectrometerHBH
approved these changes
Jan 25, 2023
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
TVMScript parser supports both `T.Buffer` and `T.buffer_decl` interchangeably, which share the same semantics in TIR AST. However, `T.buffer_decl` is usually confused with `T.decl_buffer`. To clarify the semantics, we decide to print `T.Buffer` instead. Note that this PR is backward compatible with the previous behavior, i.e. the parser still parses TVMScript with `T.decl_buffer`, and the only difference is the print now produces `T.Buffer` instead by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TVMScript parser supports both
T.BufferandT.buffer_declinterchangeably, which share the same semantics in TIR AST. However,T.buffer_declis usually confused withT.decl_buffer. To clarify the semantics, we decide to printT.Bufferinstead.Note that this PR is backward compatible with the previous behavior, i.e. the parser still parses TVMScript with
T.decl_buffer, and the only difference is the print now producesT.Bufferinstead by default.