[TVMScript] T.allocate with T.decl_buffer syntax sugar for TVMScript printer#13813
Merged
junrushao merged 1 commit intoapache:mainfrom Jan 20, 2023
Merged
[TVMScript] T.allocate with T.decl_buffer syntax sugar for TVMScript printer#13813junrushao merged 1 commit intoapache:mainfrom
T.allocate with T.decl_buffer syntax sugar for TVMScript printer#13813junrushao merged 1 commit intoapache:mainfrom
Conversation
fix outdated code fix outdated unittest `match_buffer` syntax sugar `T.allocate` and `T.decl_buffer` syntax sugar . fix
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
reviewed
Jan 20, 2023
Comment on lines
+371
to
+373
| with T.allocate([128, 128], "float32", "global") as v: | ||
| buffer = T.decl_buffer((256, 256), data=v) | ||
| T.evaluate(v) |
Member
There was a problem hiding this comment.
i think we could still do sugaring in this case, i.e.:
with T.decl_buffer((256, 256)) as buffer:
T.evaluate(buffer.data)
junrushao
approved these changes
Jan 20, 2023
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
LGTM! Please enhance the sugaring in a separate PR :-)
junrushao
pushed a commit
that referenced
this pull request
Jan 24, 2023
This PR is the follow up of #13813. We simplify the printing output of `T.allocate` with `T.decl_buffer`. For example, we have a code snippet as ```python buffer_data = T.allocate(...) buffer = T.decl_buffer(..., data=buffer_data) T.evaluate(buffer_data) ``` Originally, we skip the `T.allocate` only if the var `buffer_data` defined by `T.allocate` is used only once by the following `T.decl_buffer`. This was due to the limitation of the old printer design. But in the new printer, we may automatically replace the `buffer_data` with `buffer.data` if skipping the definition of `buffer_data`. We are able to link all `buffer_data` usages together. So the new output result will be like ```python buffer = T.decl_buffer(...) T.evaluate(buffer.data) ```
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
…ipt printer (apache#13813) This PR implements the syntax sugar of `T.allocate` with `T.decl_buffer` for new TVMScript printer. This syntax sugar will skip the `T.allocate`, when its body is a matched `T.decl_buffer`, and the `Var` defined in `T.allocate` is only used in that `T.decl_buffer`. For example, it will change ```python buffer_data = T.allocate([128, 128]) buffer = T.decl_buffer([128, 128], data=buffer_data) ``` into ```python buffer = T.decl_buffer([128, 128]) ``` but keep the following `T.allocate` unchanged: ```python buffer_data = T.allocate([128, 128]) buffer_0 = T.decl_buffer([128, 128], data=buffer_data) buffer_1 = T.decl_buffer([128, 128], data=buffer_data) ``` and ```python buffer_data = T.allocate([128, 128]) buffer = T.decl_buffer([256, 256], data=buffer_data) ```
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
This PR is the follow up of apache#13813. We simplify the printing output of `T.allocate` with `T.decl_buffer`. For example, we have a code snippet as ```python buffer_data = T.allocate(...) buffer = T.decl_buffer(..., data=buffer_data) T.evaluate(buffer_data) ``` Originally, we skip the `T.allocate` only if the var `buffer_data` defined by `T.allocate` is used only once by the following `T.decl_buffer`. This was due to the limitation of the old printer design. But in the new printer, we may automatically replace the `buffer_data` with `buffer.data` if skipping the definition of `buffer_data`. We are able to link all `buffer_data` usages together. So the new output result will be like ```python buffer = T.decl_buffer(...) T.evaluate(buffer.data) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the syntax sugar of
T.allocatewithT.decl_bufferfor new TVMScript printer. This syntax sugar will skip theT.allocate, when its body is a matchedT.decl_buffer, and theVardefined inT.allocateis only used in thatT.decl_buffer. For example, it will changeinto
but keep the following
T.allocateunchanged:and