[TIR][FIX] check args size when creating prim_func by runtime::Registry

[Ever-Kid]

default value for index_dtype_override is null, so it would be better if the registry block of te.CreatePrimFunc could check args size.

[tvm-bot]

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

• cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan _{See #10317 for details}

_{Generated by tvm-bot}

[Ever-Kid]

cc. @vinx13

[Hzfengsy]

Could you please add a regression test?

[Ever-Kid]

Could you please add a regression test?

Sure, I guess I should test te.CreatePrimFunc by runtime::Registry. Any hints where to put this testcase, like tests/cpp/data_type_rewriter_test.cc, tests/cpp/tensor_test.cc or others ?

[Hzfengsy]

After looking at the codebase again, it would be great if we can ensure this PackedFunc has two args. Another approach is adding ICHECK_EQ(args.size(), 2).

Keeping PackedFunction stable and minimal will benefit the registry system and user experience. If you want to call it from cpp side, we have API here, and no need to call PackedFunction

Also cc @junrushao

[junrushao]

That sounds reasonable to me :-)

[tqchen]

sorry i approved pre-maturely, after seeing @Hzfengsy 's comment, i agree with the accessment

[Ever-Kid]

I followed @Hzfengsy 's suggestion. And since no need to call PackedFunc, also testcases like test_tensor_layout_attr in tests/python/unittest/test_te_create_primfunc.py are quite inclusive, so I added no test.
Any other suggestions would be welcomed~ 😄