Remove tutorials CMSIS dependency when not needed#13762
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
@ashutosh-arm, @mehrdadh |
guberti
left a comment
There was a problem hiding this comment.
This looks good, but do these tutorials still need to include instructions to install CMSIS? I'd love to remove this from micro_aot.py, micro_autotune.py, and micro_tflite.py if we can.
######################################################################
#
# .. include:: ../../../../gallery/how_to/work_with_microtvm/install_dependencies.rst
#Change-Id: Ic844422c74855f774b97ea57c6cb6eac2236e29b
7f265e7 to
5a4966e
Compare
Done. Thanks for the review! |
| @@ -1,35 +0,0 @@ | |||
| .. Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Please don't remove this file as we will need it in future tutorials
There was a problem hiding this comment.
I re-added the file and edited it adding the commands to download CMSIS NN from the new GitHub location.
Change-Id: Idbaada0753a9d46cfd94f71fcb30c7f7a8a1d17d
5a4966e to
b61f2d6
Compare
* Remove tutorials CMSIS dependencies when not needed Change-Id: Ic844422c74855f774b97ea57c6cb6eac2236e29b * Address comments Change-Id: Idbaada0753a9d46cfd94f71fcb30c7f7a8a1d17d
Pr #13656 added support for CMSIS NN from a new GitHub location.
The project at the new location uses a new header
arm_acle.hwhich is not always present.This pr removes the CMSIS dependency for the tutorials in
gallery/how_to/work_with_microtvmwhen the tutorials are run with Zephyr.We need this pr, otherwise, when the docker image will be updated there will be errors, due to the missing header.