Skip to content

[ONNX] QGemm support#13747

Merged
AndrewZhaoLuo merged 1 commit intoapache:mainfrom
chengven027:add.onnx.QGemm
Jan 26, 2023
Merged

[ONNX] QGemm support#13747
AndrewZhaoLuo merged 1 commit intoapache:mainfrom
chengven027:add.onnx.QGemm

Conversation

@chengven027
Copy link
Copy Markdown
Contributor

@chengven027 chengven027 commented Jan 10, 2023

Hi, TVM
I try to add a new onnx operator QGEMM.
Please help to review,thanks. @AndrewZhaoLuo

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Jan 10, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

KJlaccHoeUM9l
KJlaccHoeUM9l reviewed Jan 10, 2023
View reviewed changes
Comment thread python/tvm/relay/frontend/onnx.py Outdated
Comment thread python/tvm/relay/frontend/onnx.py Outdated
Comment thread python/tvm/relay/frontend/onnx.py Outdated
@chengven027
Copy link
Copy Markdown
Contributor Author

chengven027 commented Jan 11, 2023

Thanks for your review. I updated the comment. Please review again, Thanks. @KJlaccHoeUM9l

@AndrewZhaoLuo
Copy link
Copy Markdown
Contributor

AndrewZhaoLuo commented Jan 19, 2023

@tvm-bot rerun

@AndrewZhaoLuo
Copy link
Copy Markdown
Contributor

AndrewZhaoLuo commented Jan 19, 2023

Sorry, I will take a look tomorrow.

KJlaccHoeUM9l
KJlaccHoeUM9l approved these changes Jan 20, 2023
View reviewed changes
Comment thread python/tvm/relay/frontend/onnx.py Outdated

@classmethod
def _impl_v1(cls, inputs, attr, params):
# http://www.xavierdupre.fr/app/mlprodict/helpsphinx/onnxops/onnx_commicrosoft_QGemm.html
Copy link
Copy Markdown
Contributor

@KJlaccHoeUM9l KJlaccHoeUM9l Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to add a link to the documentation, it's better to point to the official documentation for ORT:
https://github.com/microsoft/onnxruntime/blob/main/docs/ContribOperators.md#com.microsoft.QGemm

AndrewZhaoLuo
AndrewZhaoLuo reviewed Jan 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewZhaoLuo AndrewZhaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to fix CI issues and point documentation to official repo.

Otherwise LGTM.

@chengven027
Copy link
Copy Markdown
Contributor Author

chengven027 commented Jan 21, 2023

Done, Thanks,please review again. @AndrewZhaoLuo

@AndrewZhaoLuo AndrewZhaoLuo merged commit f7dfef4 into apache:main Jan 26, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
@chengven027 @fzi-peccia
[ONNX] QGemm support (apache#13747)
427b548 
Co-authored-by: cheng.wen <wen.cheng@intellif.com>
@ysh329 ysh329 mentioned this pull request Apr 17, 2023
Closed
@chengven027 chengven027 deleted the add.onnx.QGemm branch January 12, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewZhaoLuo AndrewZhaoLuo AndrewZhaoLuo approved these changes

+1 more reviewer

@KJlaccHoeUM9l KJlaccHoeUM9l KJlaccHoeUM9l approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chengven027 @tvm-bot @AndrewZhaoLuo @KJlaccHoeUM9l