[HotFix][docs] Use correct Colab button URL#13725
Merged
guberti merged 2 commits intoapache:mainfrom Jan 9, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Member
Author
|
Before merging this, we need to confirm this change will trigger the docs to be re-built and re-deployed. I believe that happens after every PR - if this is not the case, let me know. |
driazati
approved these changes
Jan 8, 2023
Member
driazati
left a comment
There was a problem hiding this comment.
Confirmed it works on https://pr-docs.tlcpack.ai/PR-13725/1/docs/tutorial/install.html#sphx-glr-tutorial-install-py, the deploy should happen automatically once this is merged
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
* [docs] Use correct Colab button URL * Black format conf.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #13627 added Google Colab support to the TVM tutorials, allowing them to be opened interactively with one click. This mostly works - try it yourself!
However, the button to open the tutorial in Google Colab does not render, as #13627 used the wrong URL:
The file is stored in the repo tlc-pack/web-data, not apache/web-data. This PR fixes the bug and makes the button render correctly.
cc @mehrdadh