[BugFix][TVMScript] Fix the roundtripability of intrinsic pow#13692
[BugFix][TVMScript] Fix the roundtripability of intrinsic pow#13692Hzfengsy merged 4 commits intoapache:mainfrom
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
lightzhan-intellif
changed the title
lightzhan-intellif
changed the title
|
@tvm-bot rerun |
| assert "-> None" not in script | ||
|
|
||
|
|
||
| def test_pow_roundtripable(): |
There was a problem hiding this comment.
Could you please use the ir_generator to make tests consistent in this file?
|
BTW, there are some existing logics that depend on the python API |
|
Do you mean that users can use both |
| nextafter = _op_wrapper(_tir_op.nextafter) | ||
| popcount = _op_wrapper(_tir_op.popcount) | ||
| power = _op_wrapper(_tir_op.power) | ||
| pow = _op_wrapper(_tir_op.power) # pylint: disable=redefined-builtin |
There was a problem hiding this comment.
I was thinking if we could add a pow method to tvm/tir/op.py so that it could be consistent
…#13692) * Fix the roundtripability of pow intrinsic. * fix the lint. * Fix the lint. * add tir.pow to make it consistent. Co-authored-by: lightzhan-intellif <zhan.liang@intellif.com>
4 participants
Hi,
This is a bug fix discussed here. Any further suggestion is welcome.
cc @junrushao