[CMake][OpenCL] Remove warning for OpenCL wrapper#13683
Conversation
Previously, setting `set(USE_OPENCL ON)` would result in a warning, stating that the runtime wrapper for OpenCL would be used. Since this is the desired behavior when OpenCL support is enabled, and is not something that a user should fix, this commit removes the warning.
1 similar comment
|
@tvm-bot rerun |
echuraev
left a comment
There was a problem hiding this comment.
I have added this warning message especially to notify the user that the OpenCL wrapper will be used, and it might lead to a runtime error if the OpenCL library doesn't exist on a target device.
If warning message might embarrass, let's keep just status message?
Good point, as that is a runtime error that would occur on first usage, whereas all the other library dependencies would cause a failure when importing
I like this idea, and have the message back in, but with |
Co-authored-by: Egor Churaev <egor.churaev@gmail.com>
* [CMake][OpenCL] Remove warning for OpenCL wrapper Previously, setting `set(USE_OPENCL ON)` would result in a warning, stating that the runtime wrapper for OpenCL would be used. Since this is the desired behavior when OpenCL support is enabled, and is not something that a user should fix, this commit removes the warning. * Added "STATUS" message instead of "WARNING", with more detail * "installation location" -> "library location" Co-authored-by: Egor Churaev <egor.churaev@gmail.com> Co-authored-by: Egor Churaev <egor.churaev@gmail.com>
Previously, setting
set(USE_OPENCL ON)would result in a warning, stating that the runtime wrapper for OpenCL would be used. Since this is the desired behavior when OpenCL support is enabled, and is not something that a user should fix, this commit removes the warning.