[TOPI] Expose mem_scope from generic conv2d variants to be more reusable#13680
Merged
masahi merged 1 commit intoapache:mainfrom Jan 3, 2023
cbalint13:main
Merged
[TOPI] Expose mem_scope from generic conv2d variants to be more reusable#13680masahi merged 1 commit intoapache:mainfrom cbalint13:main
masahi merged 1 commit intoapache:mainfrom
cbalint13:main
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
masahi
approved these changes
Jan 3, 2023
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
…ble (apache#13680) Expose mem_scope from generic conv2d variants to be more reusable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR enhances generic conv2d TOPI schedules to be even more reusable.
Changes:
mem_scopeDoes not change current behaviour, memory scope remains "global" by default.
Goal:
Flexibility and reusability of key generic schedules is desirable for targets, especially custom ISA/ASIC.
There are use-cases where cache memory is not directly visible ("local") but generic TOPI is still very useful as-is.
Cc @masahi , @vinx13 , @ZihengJiang please help with the review.
Thank you,
~Cristian.