[MetaSchedule] Add "disabled_pass" option in tuning API#13659
Merged
echuraev merged 2 commits intoapache:mainfrom Dec 28, 2022
Merged
[MetaSchedule] Add "disabled_pass" option in tuning API#13659echuraev merged 2 commits intoapache:mainfrom
echuraev merged 2 commits intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
masahi
approved these changes
Dec 27, 2022
echuraev
reviewed
Dec 28, 2022
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
Also, I have a question. Should we add a test for this option or not?
| seed: Optional[int] = None, | ||
| module_equality: str = "structural", | ||
| num_tuning_cores: Union[Literal["physical", "logical"], int] = "physical", | ||
| disabled_pass: Optional[Union[List[str], Set[str], Tuple[str]]] = None, |
Contributor
There was a problem hiding this comment.
Could you please add information about this parameter to the docstring?
| } | ||
| ), | ||
| executor: Optional["relay.backend.Executor"] = None, | ||
| disabled_pass: Optional[Union[List[str], Set[str], Tuple[str]]] = None, |
Now there is no way to disable passes in MetaShedule tuner. This commit adds new parameter "disabled_pass" in tuning API (tune_relay/compile_relay). It can be used for different experiments and non default behavoir.
ibsidorenko
force-pushed
the
metaschedule-disable-pass-option
branch
from
22522d8 to
545781e
Compare
Contributor
Author
I thought about that... since this is rather trivial change, not a bug fixing + it can be checked with tuning only (time consuming operation) I decided not to add unit test. |
This commit adds unit test for 'disabled_pass' parameter in MetaSchedule tuner. Test should throw TVMError exception. That's why it is marked as XFAIL.
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
* [MetaSchedule] Add "disabled_pass" option in tuning API Now there is no way to disable passes in MetaShedule tuner. This commit adds new parameter "disabled_pass" in tuning API (tune_relay/compile_relay). It can be used for different experiments and non default behavoir. * Add unit test for 'disabled_pass' parameter in MetaScheduler tuner This commit adds unit test for 'disabled_pass' parameter in MetaSchedule tuner. Test should throw TVMError exception. That's why it is marked as XFAIL.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [MetaSchedule] Add "disabled_pass" option in tuning API Now there is no way to disable passes in MetaShedule tuner. This commit adds new parameter "disabled_pass" in tuning API (tune_relay/compile_relay). It can be used for different experiments and non default behavoir. * Add unit test for 'disabled_pass' parameter in MetaScheduler tuner This commit adds unit test for 'disabled_pass' parameter in MetaSchedule tuner. Test should throw TVMError exception. That's why it is marked as XFAIL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now there is no way to disable passes in MetaShedule tuner. This commit adds new parameter
disabled_passin tuning API (tune_relay/compile_relay). It can be used for different experiments and non default behavoir.