[MetaSchedule] Fix tensorcore winograd task extraction#13625
Merged
masahi merged 3 commits intoapache:mainfrom Dec 16, 2022
Merged
[MetaSchedule] Fix tensorcore winograd task extraction#13625masahi merged 3 commits intoapache:mainfrom
masahi merged 3 commits intoapache:mainfrom
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
approved these changes
Dec 15, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Interesting! I was completely unaware of the issue, and thanks for pointing it out!
masahi
force-pushed
the
ms-winograd-task-extraction-fix
branch
from
500cfcf to
25c235c
Compare
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
* [MetaSchedule] Fix tensorcore winograd task extraction * add test * fixed target
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [MetaSchedule] Fix tensorcore winograd task extraction * add test * fixed target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both AutoTVM and AS/MS winograd are applicable, the latter is never picked by the op strategy because the AutoTVM one has a higher plevel (20 vs 15)
tvm/python/tvm/relay/op/strategy/cuda.py
Lines 271 to 276 in b16a64d
This has been fixed, and now we can properly extract FP16 winograd tasks for MS tuning.
@vinx13 @junrushao @zxybazh