Skip to content

[TOPI] Fix batch_matmul tensorcore legalize for transpose_b = False case#13618

Merged
masahi merged 3 commits intoapache:mainfrom
masahi:bmm-tc-legalize-fix
Dec 15, 2022
Merged

[TOPI] Fix batch_matmul tensorcore legalize for transpose_b = False case#13618
masahi merged 3 commits intoapache:mainfrom
masahi:bmm-tc-legalize-fix

Conversation

@masahi
Copy link
Copy Markdown
Member

@masahi masahi commented Dec 14, 2022

The hardcoded shapes

    B, M, K = x_tensor.shape
    B, N, K = y_tensor.shape

is not valid if transpose_b = False or transpose_a = True.

@vinx13

@tvm-bot
Copy link
Copy Markdown
Collaborator

tvm-bot commented Dec 14, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: topi See #10317 for details

Generated by tvm-bot

@masahi masahi merged commit 7fd0cdb into apache:main Dec 15, 2022
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
…ase (apache#13618)

* fixed tensor core batch_matmul legalize for transpose_b = False case

* add test

* clean up
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
…ase (apache#13618)

* fixed tensor core batch_matmul legalize for transpose_b = False case

* add test

* clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants