[LLVM] Use std::nullopt instead of llvm::None#13617
[LLVM] Use std::nullopt instead of llvm::None#13617masahi merged 1 commit intoapache:mainfrom kparzysz-quic:pgoopt
Conversation
Pass `std::nullopt` to initialization of `PassBuilder` for `PGOOptions`. LLVM is moving away from its own `Optional` type to `std::optional`.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
2 similar comments
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Icemist
left a comment
There was a problem hiding this comment.
LGTM. Looks backward compatible because llvm::Optional<T> has a constructor from std::nullopt_t.
It is about this change in the main branch:
LLVM::Optional<PGOOptions> PGOOpt = LLVM::None,
=>
std::optional<PGOOptions> PGOOpt = std::nullopt,
Pass `std::nullopt` to initialization of `PassBuilder` for `PGOOptions`. LLVM is moving away from its own `Optional` type to `std::optional`.
Pass `std::nullopt` to initialization of `PassBuilder` for `PGOOptions`. LLVM is moving away from its own `Optional` type to `std::optional`.
Pass
std::nulloptto initialization ofPassBuilderforPGOOptions. LLVM is moving away from its ownOptionaltype tostd::optional.