[microTVM]Add default value to unspecified project options in project API#13610
Merged
mehrdadh merged 6 commits intoapache:mainfrom Jan 4, 2023
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
mehrdadh
requested review from
gromero and
guberti
and removed request for
guberti
mehrdadh
force-pushed
the
micro/add_default_project_options
branch
3 times, most recently
from
24d1aeb to
12d3446
Compare
mehrdadh
force-pushed
the
micro/add_default_project_options
branch
from
96bbd02 to
76b9d38
Compare
areusch
reviewed
Jan 3, 2023
areusch
approved these changes
Jan 3, 2023
guberti
reviewed
Jan 4, 2023
Member
guberti
left a comment
guberti
left a comment
There was a problem hiding this comment.
LGTM, sorry for the belated review!
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
… API (apache#13610) In current TVM, project API ignores the default values that are set for each project option in a project API server. This results in extra function handlers to specify the default value for those options in runtime. This PR searches through available ProjectOptions for a project API server and adds default values for unspecified options before sending the options to API call function handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current TVM, project API ignores the default values that are set for each project option in a project API server. This results in extra function handlers to specify the default value for those options in runtime.
This PR searches through available ProjectOptions for a project API server and adds default values for unspecified options before sending the
optionsto API call function handler.