[Frontend] [ONNX] Support sequence_lens of GRU#13587
Merged
masahi merged 1 commit intoapache:mainfrom Dec 15, 2022
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
Could you please review this PR @masahi? Thanks! |
masahi
changed the title
Member
|
@tvm-bot rerun |
Member
vvchernov
reviewed
Dec 13, 2022
| # Testing with initial state | ||
| if rnn_type == "GRU": | ||
| verify_rnn( | ||
| seq_length=2, |
Contributor
There was a problem hiding this comment.
Please increase seq_length (to 4-5 or more) and batch_size (to 4-8) for correct test of sequence with different lengths
| @@ -737,6 +737,7 @@ def gru_cell( | |||
| n_act=_op.tanh, | |||
| backwards=False, | |||
| linear_before_reset=True, | |||
Contributor
There was a problem hiding this comment.
Please add description of arguments linear_before_reset and sequence_lens
jacquesguan
force-pushed
the
gru_onnx
branch
from
140cc4b to
29241c8
Compare
Support convert sequence_lens input of GRU.
jacquesguan
force-pushed
the
gru_onnx
branch
from
29241c8 to
67e7dc4
Compare
masahi
approved these changes
Dec 15, 2022
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
[Frontend] [ONNX] Support sequence_lens of GRU. Support convert sequence_lens input of GRU.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
[Frontend] [ONNX] Support sequence_lens of GRU. Support convert sequence_lens input of GRU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support convert sequence_lens input of GRU.