[TIR][Schedule] Support for specific consumer block targeting in cache_write#13510
Merged
Hzfengsy merged 1 commit intoDec 12, 2022
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
97c4721 to
37bbda4
Compare
Hzfengsy
approved these changes
Dec 12, 2022
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
…e_write (apache#13510) Add optional consumer blocks to cache_write.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…e_write (apache#13510) Add optional consumer blocks to cache_write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this change try add optional
consumer_blocksparam tocache_writesymmetrically, following change oncache_readof #12505.This is helpful when there are multiple consumers to the targeting block who also write to global output, and when we do
cache_write, we may want to control some of the consumers read data reside on cache.As a comparation, for
s.cache_read(B, 0, "cache_scope", consumer_blocks=[B]):For
s.cache_write(P, 0, "cache_scope", consumer_blocks=[B])cc @Hzfengsy @jwfromm