[Relay][Topi] Hook up LayerNorm to new Topi#12935
Closed
AndrewZhaoLuo wants to merge 17 commits intoapache:mainfrom
Closed
[Relay][Topi] Hook up LayerNorm to new Topi#12935AndrewZhaoLuo wants to merge 17 commits intoapache:mainfrom
AndrewZhaoLuo wants to merge 17 commits intoapache:mainfrom
Conversation
vinx13
reviewed
Sep 29, 2022
Member
vinx13
left a comment
There was a problem hiding this comment.
I'm wondering removing simplification for later norm affects non-metaschedule workflow. We didn't implement topi schedule for layer norm, I'm not sure if the default schedule_injective works well.
Btw there are also some unrelated (.csv, .md) files in this PR added by mistake.
Contributor
Author
|
I have removed the unneeded files. Good point about non-metaschedule workflows. I will see what I can do here. |
Member
|
Any update? Also interested in using fused layer norm. |
Contributor
Author
|
Ah yes, I will try to get to this during the next week where I will have time.
|
332a388 to
21b8e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes layer_norm relay op dispatch to new topi committed in PR #12864.
It removes LayerNorm from simplify inference pass now that we actually have compute.
Using TIR CSE elimination pass with FP16 layernorm also necessitates the handling of FP16 type when packing args for CUDA.