[BUILD] Re-enable ccache by default#12839
Merged
areusch merged 8 commits intoapache:mainfrom Sep 26, 2022
Merged
Conversation
Previously ccache was disabled because of possible issues with hexagon. Re-enabling it to provide a best effort attempt at using it.
driazati
reviewed
Sep 19, 2022
areusch
reviewed
Sep 19, 2022
| list(APPEND RUNTIME_SRCS ${RUNTIME_PIPELINE_SRCS}) | ||
| endif(USE_PIPELINE_EXECUTOR) | ||
|
|
||
| #Caches the build. |
Contributor
There was a problem hiding this comment.
nit: spaces after comment #
|
|
||
| if(USE_CCACHE) # True for AUTO, ON, /path/to/ccache | ||
| if(DEFINED CXX_COMPILER_LAUNCHER OR DEFINED C_COMPILER_LAUNCHER) | ||
| message(STATUS "CXX_COMPILER_LAUNCHER or C_COMPILER_LAUNCHER already defined, not using ccache") |
Contributor
There was a problem hiding this comment.
should this be ERROR if USE_CCACHE is on?
| else() | ||
| message(STATUS "Didn't find the path to CCACHE, disabling ccache") | ||
| endif(CCACHE_FOUND) | ||
| elseif("${USE_CCACHE}" MATCHES ${IS_TRUE_PATTERN}) |
Contributor
There was a problem hiding this comment.
possible to collapse this with the previous if case?
Contributor
Author
There was a problem hiding this comment.
I think the logic is clearer this way.
driazati
approved these changes
Sep 19, 2022
Member
driazati
left a comment
driazati
left a comment
There was a problem hiding this comment.
a couple more nits but looks fine once those are addressed
|
BTW, why not to use an external module? |
Contributor
Author
|
@KOLANICH we don't want to add any unnecessary dependencies. |
driazati
reviewed
Sep 19, 2022
| # under the License. | ||
|
|
||
| if(USE_CCACHE) # True for AUTO, ON, /path/to/ccache | ||
| if(DEFINED CXX_COMPILER_LAUNCHER OR DEFINED C_COMPILER_LAUNCHER) |
Member
There was a problem hiding this comment.
also have no idea how cmake works but aren't these vars supposed to have the CMAKE_ prefix everywhere?
Suggested change
| if(DEFINED CXX_COMPILER_LAUNCHER OR DEFINED C_COMPILER_LAUNCHER) | |
| if(DEFINED CMAKE_CXX_COMPILER_LAUNCHER OR DEFINED CMAKE_C_COMPILER_LAUNCHER) |
Contributor
Author
There was a problem hiding this comment.
https://cmake.org/cmake/help/latest/prop_tgt/LANG_COMPILER_LAUNCHER.html. It appears to be CXX_COMPILER_LAUNCHER
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
areusch
approved these changes
Sep 26, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [BUILD] Re-enable ccache by default Previously ccache was disabled because of possible issues with hexagon. Re-enabling it to provide a best effort attempt at using it. * set tvm_option, set variables correctly * clean up comment, fatal error if launcher is defined with USE_CCACHE=ON * add ccache to libinfo * more libinfo * add launcher to summary, move ccache to seperate file * Update cmake/utils/Summary.cmake Co-authored-by: driazati <9407960+driazati@users.noreply.github.com> * correct name for Summary.cmake Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously ccache was disabled because of possible issues with hexagon. Re-enabling it to provide a best effort attempt at using it.
@driazati @cconvey