Skip to content

[TRT] Add check to use setBindingDimensions if TRT>=6.0.1#11178

Merged
comaniac merged 1 commit intoapache:mainfrom
apivovarov:trt_non_implicit_batch
May 2, 2022
Merged

[TRT] Add check to use setBindingDimensions if TRT>=6.0.1#11178
comaniac merged 1 commit intoapache:mainfrom
apivovarov:trt_non_implicit_batch

Conversation

@apivovarov
Copy link
Copy Markdown
Contributor

TRT Dynamic batching with use_implicit_batch=False uses nvinfer1::IExecutionContext::setBindingDimensions() which is not available before TRT 6.0.1.

This PR adds TRT version check around the code block which uses setBindingDimensions().

Related PR: #8461

@apivovarov apivovarov force-pushed the trt_non_implicit_batch branch from 954b494 to ceda892 Compare April 29, 2022 07:24
@apivovarov
Copy link
Copy Markdown
Contributor Author

@comaniac @ziyu-guo This fix it is similar to #11154. Can you have a look?

Comment thread src/runtime/contrib/tensorrt/tensorrt_runtime.cc
Copy link
Copy Markdown
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit 6e23e22 into apache:main May 2, 2022
@comaniac
Copy link
Copy Markdown
Contributor

comaniac commented May 2, 2022

Thanks @apivovarov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants