Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #746 +/- ##
===========================================
- Coverage 62.15% 62.13% -0.03%
===========================================
Files 702 702
Lines 40680 40738 +58
Branches 5780 5801 +21
===========================================
+ Hits 25286 25313 +27
- Misses 14613 14634 +21
- Partials 781 791 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Good work!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Configuration
Write Configuration:
Table: "testTable0"
TAG columns: 2 (id0, id1) — STRING, PLAIN, UNCOMPRESSED
FIELD columns: 3 (s0, s1, s2) — INT64, PLAIN, UNCOMPRESSED
Devices: 10 per flush
Timestamps: 100 per device per flush
Rows per flush: 1000 (10 devices × 100 timestamps)
Flush cycles: 10
Total rows: 10000
Read Configuration:
Query: full table scan (time range [0, INT64_MAX])
Mode: row-by-row iteration via TableResultSet::next()
Sample points: every 2000 rows (5 samples total)
Memory Statistics & Tracking for TsFile C++
1. Write & Flush Behavior
2. Overall Memory Growth During Write
3. Residual Memory After Writer Close
4. Read Process Memory
Root cause: TableResultSet::next() allocates string values from a PageArena, which is an arena allocator — it only frees memory in bulk on destroy(), not per-allocation. Previous rows' string memory becomes unreachable but stays in the arena.
TSBLOCK (74.5 KB) is stable — decoded data buffers are reused across pages.
5. Residual Memory After Reader Close