Skip to content

[storm-client] Add missing logging to TridentBoltExecutor on tuple count mismatch failures #8414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzo1 merged 1 commit into from
Mar 2, 2026
Merged

[storm-client] Add missing logging to TridentBoltExecutor on tuple count mismatch failures #8414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion storm-client/src/jvm/org/apache/storm/trident/topology/TridentBoltExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,13 @@
import org.apache.storm.utils.RotatingMap;
import org.apache.storm.utils.TupleUtils;
import org.apache.storm.utils.Utils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class TridentBoltExecutor implements IRichBolt {
public static final String COORD_STREAM_PREFIX = "$coord-";
private static final Logger LOG = LoggerFactory.getLogger(TridentBoltExecutor.class);

Map<GlobalStreamId, String> batchGroupIds;
Map<String, CoordSpec> coordSpecs;
Map<String, CoordCondition> coordConditions;
Expand Down Expand Up @@ -160,7 +164,8 @@ private void checkFinish(TrackedBatch tracked, Tuple tuple, TupleType type) {
if (tracked.receivedTuples == tracked.expectedTupleCount) {
finishBatch(tracked, tuple);
} else {
//TODO: add logging that not all tuples were received
LOG.warn("Failing batch {}: expected {} tuples but only received {}",
tracked.info.batchId, tracked.expectedTupleCount, tracked.receivedTuples);
failBatch(tracked);
collector.fail(tuple);
failed = true;
Expand Down