Skip to content

[storm-client] Replace e.printStackTrace() with SLF4J logging in ConfigurableTopology #8413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reiabreu merged 1 commit into from
Mar 2, 2026
Merged

[storm-client] Replace e.printStackTrace() with SLF4J logging in ConfigurableTopology #8413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion storm-client/src/jvm/org/apache/storm/topology/ConfigurableTopology.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
import org.apache.storm.shade.org.yaml.snakeyaml.Yaml;
import org.apache.storm.shade.org.yaml.snakeyaml.constructor.SafeConstructor;
import org.apache.storm.utils.Utils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* Extensions of this class takes a reference to one or more configuration files. The main() method should call ConfigurableTopology.start()
Expand All @@ -60,6 +62,7 @@
* </pre>
**/
public abstract class ConfigurableTopology {
private static final Logger LOG = LoggerFactory.getLogger(ConfigurableTopology.class);

protected Config conf = new Config();

Expand Down Expand Up @@ -120,7 +123,7 @@ protected int submit(String name, Config conf, TopologyBuilder builder) {
StormSubmitter.submitTopology(name, conf,
builder.createTopology());
} catch (Exception e) {
e.printStackTrace();
LOG.error("Failed to submit topology {}", name, e);
return -1;
}
return 0;
Expand Down