Skip to content

Add dockerfile and image releasing scripts#159

Merged
kezhenxu94 merged 2 commits into
apache:masterfrom
Superskyyy:docker-image-integration
Sep 9, 2021
Merged

Add dockerfile and image releasing scripts#159
kezhenxu94 merged 2 commits into
apache:masterfrom
Superskyyy:docker-image-integration

Conversation

@Superskyyy

@Superskyyy Superskyyy commented Sep 8, 2021

Copy link
Copy Markdown
Member

This PR adds a Dockerfile and corresponding Makefile for building and releasing the Python agent images.

Also adds docs on how-to-release and how-to-use.

Closes apache/skywalking#7461

Signed-off-by: Superskyyy Superskyyy@outlook.com

Signed-off-by: Superskyyy <Superskyyy@outlook.com>
@wu-sheng

wu-sheng commented Sep 8, 2021

Copy link
Copy Markdown
Member

I recommend python repo begins to consider moving all document into website, as it becomes larger and more official.
Only need to organize the structure, and add menu.yaml. Please take main repo or java repo as an example.

@Superskyyy

Copy link
Copy Markdown
Member Author

I recommend python repo begins to consider moving all document into website, as it becomes larger and more official.
Only need to organize the structure, and add menu.yaml. Please take main repo or java repo as an example.

I can work on that tomorrow. 👨‍🍳

@kezhenxu94 kezhenxu94 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM

I recommend python repo begins to consider moving all document into website, as it becomes larger and more official.
Only need to organize the structure, and add menu.yaml. Please take main repo or java repo as an example.

I can work on that tomorrow. 👨‍🍳

Let's do this in another PR, which doesn't need to be included in the release process

Comment thread docs/How-to-release-docker.md Outdated
Comment thread docker/README.md Outdated
Signed-off-by: Superskyyy <Superskyyy@outlook.com>

@kezhenxu94 kezhenxu94 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] provide official SkyWalking Python agent Docker image

3 participants