Feature/repair kafka3.7.x#708
Closed
darkness-2nd wants to merge 2 commits intoapache:mainfrom
darkness-2nd:feature/repairKafka3.7.x
Closed
Feature/repair kafka3.7.x#708darkness-2nd wants to merge 2 commits intoapache:mainfrom darkness-2nd:feature/repairKafka3.7.x
darkness-2nd wants to merge 2 commits intoapache:mainfrom
darkness-2nd:feature/repairKafka3.7.x
Conversation
…e pull message method
…e pull message method
Member
|
Why 3.7 plugin becomes a new plugin? Could you explain what you did? |
Contributor
Author
I did not get your "you should add more versions to support your new implementations for newer versions", you mean I should only add version into skywalking-plugin.def and do impl in module kafka-plugin? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.