Merged
Conversation
wu-sheng
reviewed
Jul 27, 2023
wu-sheng
reviewed
Jul 27, 2023
apm-sniffer/apm-sdk-plugin/resteasy-plugin/resteasy-server-6.x-plugin/pom.xml
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Jul 27, 2023
...ache/skywalking/apm/plugin/resteasy/v6/server/SynchronousDispatcherExceptionInterceptor.java
Outdated
Show resolved
Hide resolved
…er-6.x-plugin's compiler version to jdk11
wu-sheng
approved these changes
Jul 27, 2023
Contributor
Author
|
@wu-sheng btw, when will skywalking 9.0.0 be released? |
Member
|
At least end of next month, the last 8.x released last month. |
yangyulely
pushed a commit
to yangyulely/skywalking-java
that referenced
this pull request
May 25, 2024
wu-sheng
reviewed
Oct 15, 2024
|
|
||
| public class SynchronousDispatcherInstrumentation extends ClassInstanceMethodsEnhancePluginDefine { | ||
|
|
||
| private static final String ENHANCE_CLASS = "org.jboss.resteasy.core.SynchronousDispatcher"; |
Member
There was a problem hiding this comment.
@Leibnizhu We received a report from slack that all v3/v4/v6 plugins of RESTEasy are using the same target class without witness class. It seems to have conflicts.
Contributor
Author
There was a problem hiding this comment.
Where can I find more information related to witness class ? or in other words, how should I fix it?
Member
There was a problem hiding this comment.
Read point 4 here.
Witness class is using version specific class names or methods to separate versions in the runtime.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an agent plugin to support RESTEasy 6.x
Add a test case for the new plugin, refer to the doc
Add a component id in the component-libraries.yml
Add a logo in the UI repo
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes : NO
Update the
CHANGESlog.Skywalking already supports Resteasy 3.x and 4.x. Referrers to RESTEASY-3007, Resteasy 6 has migrated from Jakarta REST 2.1 to Jakarta REST 3.0.
Therefore, when applying skywalking's Resteasy 4.x javaagent to a Resteasy 6.x application, it throws
NoSuchMethodErrorlike belows:this PR:
support-version.list)