Closed
Conversation
jovany-wang
suggested changes
Jul 29, 2019
Contributor
jovany-wang
left a comment
jovany-wang
left a comment
There was a problem hiding this comment.
Left some minor comments. Others looks fine to me overall.
include/CErrorMessage.h
Outdated
| }; | ||
| #endif | ||
| #endif //__C_CLIENT_ERROR_H__ No newline at end of file | ||
| #endif //__C_CLIENT_ERROR_H__ No newline at end of file |
Contributor
There was a problem hiding this comment.
Append a new blank line at the end of this file.
| void setErr(std::string str); | ||
|
|
||
| std::string getErr(); | ||
| std::string getErr(); |
Contributor
There was a problem hiding this comment.
std::string getErr() const;
ifplusor
reviewed
Aug 2, 2019
| } | ||
|
|
||
| for (int i = 0; i < m_namesrvAddrList.size(); i++) { | ||
| for (unsigned i = 0; i < m_namesrvAddrList.size(); i++) { |
Contributor
Author
Member
|
it seems duplicated with #172 , could you please check and close one of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Format the code and remove warnings
Brief changelog
MQClientErrorContainer.cpp
MQClientErrorContainer.h
.........
Verifying this change
success
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.