Support set connectionTimeout param#410
Conversation
|
This fix itself seems fine, but are there any concerns about using the C++ API in other places? |
|
@hrsakai C and C++ API are released as a whole for source code and pre-built binaries. I think the Node.js client uses the C API due to historical reasons. Using C++ API should be okay. They make no difference from a perspective of Node.js client users. |
|
@BewareMyPower |
We already have a handle leak check here: pulsar-client-node/package.json Line 23 in b79ead0 The C API just wraps the C++ API, so it should not be expected if we turn to the C++ API directly. |
hrsakai
left a comment
There was a problem hiding this comment.
LGTM
(Since the C++ API and the C API will be mixed, I would like to consider refactoring it in the future.)
(cherry picked from commit f25b90d)
Motivation
In the C++ client, the
connectionTimeoutparameter controls the time allowed to establish a connection, with a default value of 10 secondshttps://github.com/apache/pulsar-client-cpp/blob/4ba83e83fbb4319c0b4cda82372caf042e9ccaa6/lib/ClientConnection.cc#L184-L185
We need to expose this config on node.js client.
Modifications
connectionTimeoutMsconfigurationDocumentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)