Merged
Conversation
Contributor
Author
|
Removed file extensions from all $ npm run lint
> pulsar-client@1.10.0-rc.0 lint
> clang-format-lint src/*.cc src/*.h && eslint --ext .js .
/home/massakam/github/pulsar-client-node/GenCertFile.js
20:24 error Unexpected use of file extension "js" for "./src/Client.js" import/extensions
/home/massakam/github/pulsar-client-node/index.js
21:35 error Unexpected use of file extension "js" for "./src/AuthenticationTls.js" import/extensions
22:38 error Unexpected use of file extension "js" for "./src/AuthenticationAthenz.js" import/extensions
23:37 error Unexpected use of file extension "js" for "./src/AuthenticationToken.js" import/extensions
24:38 error Unexpected use of file extension "js" for "./src/AuthenticationOauth2.js" import/extensions
25:24 error Unexpected use of file extension "js" for "./src/Client.js" import/extensions
/home/massakam/github/pulsar-client-node/pkg/load_test.js
20:24 error Unexpected use of file extension "js" for "../index.js" import/extensions
/home/massakam/github/pulsar-client-node/tests/client.test.js
20:29 error Unexpected use of file extension "js" for "./http_utils.js" import/extensions
21:24 error Unexpected use of file extension "js" for "../index.js" import/extensions
/home/massakam/github/pulsar-client-node/tests/consumer.test.js
20:24 error Unexpected use of file extension "js" for "../index.js" import/extensions
/home/massakam/github/pulsar-client-node/tests/end_to_end.test.js
21:24 error Unexpected use of file extension "js" for "../index.js" import/extensions
312:14 warning Unexpected constant condition no-constant-condition
357:26 warning 'message' is defined but never used no-unused-vars
357:35 warning 'reader' is defined but never used no-unused-vars
389:5 warning Test has no assertions jest/expect-expect
425:20 warning 'message' is defined but never used no-unused-vars
425:29 warning 'messageConsumer' is defined but never used no-unused-vars
435:26 warning 'message' is defined but never used no-unused-vars
435:35 warning 'messageConsumer' is defined but never used no-unused-vars
/home/massakam/github/pulsar-client-node/tests/producer.test.js
20:24 error Unexpected use of file extension "js" for "../index.js" import/extensions
/home/massakam/github/pulsar-client-node/tests/reader.test.js
21:24 error Unexpected use of file extension "js" for "../index.js" import/extensions
✖ 21 problems (13 errors, 8 warnings) |
RobertIndie
approved these changes
Jul 20, 2023
shibd
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There seems to be a security vulnerability in the
semvermodule that@mapbox/node-pre-gypdepends on, so I will upgrade these.https://nvd.nist.gov/vuln/detail/CVE-2022-25883
Modifications
@mapbox/node-pre-gypto 1.0.11semverto versions with vulnerability fixesVerifying this change
Documentation
doc-not-needed