fixes bug when using with pouchdb-async-storage

[yonahforst]

addresses nolanlawson/pouchdb-async-storage#6

[nolanlawson]

Thanks! However, this seems to be a bug caused by subtle differences between webpack/browserify. So your PR is failing the tests because it breaks Browserify.

I suggest a better way to solve this: create our own requestWrapper.js that simply wraps request, then create a requestWrapper-browser.js. The reason I am guessing this will work is because it is the strategy we use everywhere else (see all the various -browser.js files), and it seems to be working for webpack users.

Maybe we should also start testing Webpack in Travis.

[yonahforst]

Ok. I'd love to submit a pr with that fix but I'm still really new to all these components. Maybe once I get a bit more comfortable.

Also, not to hijack this thread, but the other issue is that even once I'm able to run it on react native, the promises never resolve. Any ideas what could be causing this?

On Thu, Dec 24, 2015 at 1:58 AM, Nolan Lawson [email protected]
wrote:

Thanks! However, this seems to be a bug caused by subtle differences between webpack/browserify. So your PR is failing the tests because it breaks Browserify.
I suggest a better way to solve this: create our own requestWrapper.js that simply wraps request, then create a requestWrapper-browser.js. The reason I am guessing this will work is because it is the strategy we use everywhere else (see all the various -browser.js files), and it seems to be working for webpack users.

Maybe we should also start testing Webpack in Travis.

Reply to this email directly or view it on GitHub:
#4695 (comment)

[nolanlawson]

I'm not sure. Is that on iOS or Android? If you can try to debug, that would be helpful. Very few people are playing around with PouchDB+ReactNative in my experience. (Also please open a separate issue for that. :))

[nolanlawson]

Opening a new issue as #4700, thanks for the clues about what's going wrong here.