This repository was archived by the owner on May 10, 2024. It is now read-only.
Add option for external C++ development toolchain, use C++11, configure libparquet library / header installation#13
Closed
wesm wants to merge 14 commits intoapache:masterfrom
Closed
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes no functional changes to the codebase, but is more a reorganization for using parquet-cpp as a building block for other native code projects. After this I'm going to start working on functional unit tests and working toward a complete reader / writer implementation.
Notably this patch removes the thirdparty packages and will rely either on cloudera/native-toolchain for development / linking or system-level dynamic libraries. You can also perform out-of-source builds.
I have not tried getting Travis CI to work with the native toolchain; I may enlist the help of @grundprinzip on this portion.