tools/[Rust|D]: Fix build break for RISC-V#12838
tools/[Rust|D]: Fix build break for RISC-V#12838xiaoxiang781216 merged 1 commit intoapache:masterfrom
Conversation
|
@no1wudi I solved this issue a long time ago, but forgot to submit it... could you fix the similar issue in LDC2(dlang) at the same time? |
Rust/D support for RISC-V is broken after apache#11549, since the target triple is quite different bewteen Rust/D toolchain and GCC, only few RISC-V targets are supported by Rust toolchain now, so it's better to construct target triple in Rust.defs/D.defs for RISC-V.
OK |
|
Sorry @no1wudi I think CONFIG_ARCH_RV_ISA_F and CONFIG_ARCH_RV_ISA_D don't exist: tools/Rust.defs In my upcoming PR, I propose to change them to CONFIG_ARCH_FPU and CONFIG_ARCH_DPFPU: tools/Rust.defs (This usage of CONFIG_ARCH_FPU and CONFIG_ARCH_DPFPU is consistent with Toolchain.defs) My PR will also fix the Rust Build |
|
@lupyuen Sorry for this issue, let's submit a standalone patch to fix it? |
|
@no1wudi Yep I'll submit a patch now for D.defs and Rust.defs. My Dockerfile testing is taking a while, so I'll patch the other files later. Thanks! |
Summary
Rust/D support for RISC-V is broken after #11549,
since the target triple is quite different bewteen Rust/D toolchain and GCC,
only few RISC-V targets are supported by Rust toolchain now, so it's better to
construct target triple in Rust.defs/D.defs for RISC-V.
Impact
Minor
Testing
Local machine