This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Fix C++ unit tests#9349
Merged
cjolivier01 merged 2 commits intoapache:masterfrom Jan 12, 2018
Merged
Conversation
cjolivier01
suggested changes
Jan 8, 2018
| set(UNITTEST_STATIC_LINK ON) | ||
| endif() | ||
|
|
||
| if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") |
Member
There was a problem hiding this comment.
This should be part of the BEGIN_WHOLE_ARCHIVE/E#ND_WHOLE_ARCHIVE definition in the top-level CMakeLists.txt
lebeg
force-pushed
the
link_fix
branch
3 times, most recently
from
7e35588 to
e1fd101
Compare
Contributor
Author
|
The verification requires on dmlc:master 'Add fully qualified type on define default_real_t' #317 to be merged first. |
Contributor
Author
|
@cjolivier01 Could you take another look please? |
cjolivier01
approved these changes
Jan 12, 2018
| set(END_WHOLE_ARCHIVE -Wl,--no-whole-archive) | ||
| elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang") | ||
| # using regular Clang or AppleClang | ||
| set(BEGIN_WHOLE_ARCHIVE -Wl,-force_load) |
Member
There was a problem hiding this comment.
nit: in the interest of completeness and readability, it would be nice to have a set(END_WHOLE_ARCHIVE "") here
yuxiangw
pushed a commit
to yuxiangw/incubator-mxnet
that referenced
this pull request
Jan 25, 2018
* Removed tabs from CMakeLists.txt * Fixed symbol linking in unit tests
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
* Removed tabs from CMakeLists.txt * Fixed symbol linking in unit tests
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
* Removed tabs from CMakeLists.txt * Fixed symbol linking in unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the C++ unit tests. The operation registrations were not invoked due to symbol stripping by the linker on Mac (clang).
Dependencies
This change depends on:
Checklist
Essentials
make lint)Changes