Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX]package libopenblas.so.0 correctly in MXNet v1.8.x wheels#20086

Merged
mseth10 merged 2 commits into
apache:v1.8.xfrom
access2rohit:v1.8.x
Mar 24, 2021
Merged

[BUGFIX]package libopenblas.so.0 correctly in MXNet v1.8.x wheels#20086
mseth10 merged 2 commits into
apache:v1.8.xfrom
access2rohit:v1.8.x

Conversation

@access2rohit
Copy link
Copy Markdown
Contributor

@access2rohit access2rohit commented Mar 23, 2021

Description

packaging libopenblas.so.0, dnnl_version.h and dnnl_config.h correctly from appropriate locations.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@access2rohit access2rohit requested a review from szha as a code owner March 23, 2021 20:33
@mxnet-bot
Copy link
Copy Markdown

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, clang, miscellaneous, sanity, centos-gpu, unix-gpu, unix-cpu, windows-gpu, website, centos-cpu, windows-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Mar 23, 2021
@access2rohit access2rohit changed the title [WIP][BUGFIX]package libopenblas.so.0 correctly in MXNet v1.8.x wheels [BUGFIX]package libopenblas.so.0 correctly in MXNet v1.8.x wheels Mar 23, 2021
@access2rohit
Copy link
Copy Markdown
Contributor Author

access2rohit commented Mar 23, 2021

Reason why this issue wasn't caught by our CD pipeline is here: #20088

@access2rohit
Copy link
Copy Markdown
Contributor Author

access2rohit commented Mar 23, 2021

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 23, 2021
@access2rohit
Copy link
Copy Markdown
Contributor Author

@leezu @mseth10 @szha please review

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 24, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Mar 24, 2021
Copy link
Copy Markdown
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Mar 24, 2021
@access2rohit
Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [all]

@mxnet-bot
Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-cpu, windows-cpu, windows-gpu, sanity, unix-gpu, miscellaneous, centos-cpu, clang, website, edge, centos-gpu]

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 24, 2021
@mseth10 mseth10 merged commit 0065b61 into apache:v1.8.x Mar 24, 2021
mseth10 pushed a commit to mseth10/incubator-mxnet that referenced this pull request Mar 24, 2021
…ache#20086)

* packaging libopenblas.so.0, dnnl_version.h and dnnl_config.h correctly

* Re-Trigger build

Co-authored-by: Rohit Kumar Srivastava <srivastava.141@buckeyemail.osu.edu>
roclark added a commit to NVIDIA/Imageinary that referenced this pull request Mar 25, 2021
MXNet 1.8.0 has an error loading the libopenblas.so.0 library and causes
the package to fail immediately. This will be fixed in a future version
of MXNet, but version 1.8.0 will likely always be broken and should be
ignored. For more information, see apache/mxnet#20086

Signed-Off-By: Robert Clark <roclark@nvidia.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants