Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Backport the GroupNorm implementation fix and introduce a migration path#18268

Open
nickguletskii wants to merge 9 commits intoapache:v1.xfrom
nickguletskii:bugfix/groupnorm_backport
Open

[v1.x] Backport the GroupNorm implementation fix and introduce a migration path#18268
nickguletskii wants to merge 9 commits intoapache:v1.xfrom
nickguletskii:bugfix/groupnorm_backport

Conversation

@nickguletskii
Copy link
Copy Markdown
Contributor

Description

This is a backport of #18199 for MXNet 1.x that doesn't break compatibility with existing models.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add a switch that switches between the old and the new implementation.
  • Update the the unit test to test both implementations.
  • Document the operator's switch.
  • Document the switch in the Gluon block.
  • Add a warning in the Gluon interface.

Comments

  • Since GroupNorm will be moved to npx in MXNet 2.0, introducing a (dummy) v2 parameter in MXNet 2.0 is not necessary, since backward compatibility will be broken anyways.
  • Should this be included with MXNet 1.7?

@nickguletskii nickguletskii requested a review from szha as a code owner May 9, 2020 10:38
@mxnet-bot
Copy link
Copy Markdown

Hey @nickguletskii , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, edge, centos-cpu, unix-cpu, centos-gpu, windows-gpu, miscellaneous, clang, unix-gpu, sanity, windows-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@nickguletskii
Copy link
Copy Markdown
Contributor Author

The linter checks are currently failing due to false positives in unrelated files: #18269

@nickguletskii nickguletskii force-pushed the bugfix/groupnorm_backport branch from a32b4e8 to b195706 Compare May 11, 2020 22:27
@nickguletskii
Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [edge, unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-gpu, edge]

@nickguletskii nickguletskii force-pushed the bugfix/groupnorm_backport branch from 3a4b440 to 03263e1 Compare May 26, 2020 17:48
@nickguletskii
Copy link
Copy Markdown
Contributor Author

@mxnet-bot run ci [all]

@mxnet-bot
Copy link
Copy Markdown

Jenkins CI successfully triggered : [windows-cpu, unix-cpu, miscellaneous, centos-gpu, unix-gpu, clang, windows-gpu, sanity, centos-cpu, website, edge]

@nickguletskii nickguletskii force-pushed the bugfix/groupnorm_backport branch from 03263e1 to 38cfd14 Compare May 29, 2020 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants