Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] FFI: atleast_1/2/3d#17897

Merged
haojin2 merged 2 commits intoapache:masterfrom
Tommliu:ffi_atleast
Apr 8, 2020
Merged

[Numpy] FFI: atleast_1/2/3d#17897
haojin2 merged 2 commits intoapache:masterfrom
Tommliu:ffi_atleast

Conversation

@Tommliu
Copy link
Copy Markdown
Contributor

@Tommliu Tommliu commented Mar 24, 2020

Description

New FFI imperative invocation for operator : atleast_1/2/3d

Numpy Operator Old FFI (ctypes) (us) New FFI (cython) (us)
atleast_1d 26.72 16.74
atleast_2d 26.78 16.49
atleast_3d 26.92 16.43

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Tommliu Tommliu requested a review from szha as a code owner March 24, 2020 06:31
@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 24, 2020

Hey @Tommliu , Thanks for submitting the PR
Once your PR is ready for CI checks, invoke the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, windows-gpu, unix-gpu, centos-cpu, unix-cpu, website, edge, miscellaneous, sanity, clang, windows-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@haojin2 haojin2 added the Numpy label Mar 24, 2020
@Tommliu
Copy link
Copy Markdown
Contributor Author

Tommliu commented Mar 25, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 25, 2020

Jenkins CI successfully triggered : [windows-gpu]

hzfan
hzfan approved these changes Mar 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tommliu
Copy link
Copy Markdown
Contributor Author

Tommliu commented Mar 25, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 25, 2020

Jenkins CI successfully triggered : [windows-gpu]

@Tommliu
Copy link
Copy Markdown
Contributor Author

Tommliu commented Mar 25, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 25, 2020

Jenkins CI successfully triggered : [windows-gpu]

@Tommliu
Copy link
Copy Markdown
Contributor Author

Tommliu commented Mar 26, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 26, 2020

Jenkins CI successfully triggered : [windows-gpu]

@Tommliu
Copy link
Copy Markdown
Contributor Author

Tommliu commented Apr 7, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 7, 2020

Jenkins CI successfully triggered : [windows-gpu]

@haojin2 haojin2 merged commit f906a02 into apache:master Apr 8, 2020
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@Tommliu @sxjscience
ffi_atleast_1/2/3d (apache#17897)
905eb27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@hzfan hzfan hzfan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Tommliu @mxnet-bot @hzfan @haojin2