Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] add: numpy op rollaxis#17865

Merged
haojin2 merged 1 commit intoapache:masterfrom
yijunc:rollaxis
Apr 10, 2020
Merged

[Numpy] add: numpy op rollaxis#17865
haojin2 merged 1 commit intoapache:masterfrom
yijunc:rollaxis

Conversation

@yijunc
Copy link
Copy Markdown
Contributor

@yijunc yijunc commented Mar 18, 2020

Description

Implement Numpy operator rollaxis

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@yijunc yijunc requested a review from szha as a code owner March 18, 2020 06:25
@haojin2 haojin2 self-assigned this Mar 18, 2020
@haojin2 haojin2 added the Numpy label Mar 18, 2020
@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 26, 2020

Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]

@yijunc
Copy link
Copy Markdown
Contributor Author

yijunc commented Mar 26, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Mar 26, 2020

Jenkins CI successfully triggered : [windows-cpu, centos-gpu, sanity, centos-cpu, edge, clang, website, miscellaneous, windows-gpu, unix-gpu, unix-cpu]

@yijunc yijunc force-pushed the rollaxis branch 3 times, most recently from 75df9d1 to a0fd070 Compare April 1, 2020 06:03
haojin2
haojin2 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should add the new ffi wrapper in a later PR tho.

@haojin2
Copy link
Copy Markdown
Contributor

haojin2 commented Apr 1, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 1, 2020

Jenkins CI successfully triggered : [unix-gpu]

@yijunc
Copy link
Copy Markdown
Contributor Author

yijunc commented Apr 9, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 9, 2020

Jenkins CI successfully triggered : [unix-cpu]

@yijunc
Copy link
Copy Markdown
Contributor Author

yijunc commented Apr 9, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 9, 2020

Jenkins CI successfully triggered : [unix-gpu]

@haojin2
Copy link
Copy Markdown
Contributor

haojin2 commented Apr 9, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 9, 2020

Jenkins CI successfully triggered : [unix-gpu]

@yijunc
Copy link
Copy Markdown
Contributor Author

yijunc commented Apr 10, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Apr 10, 2020

Jenkins CI successfully triggered : [unix-gpu]

@haojin2 haojin2 merged commit 3dab617 into apache:master Apr 10, 2020
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@yijunc @sxjscience
add: numpy rollaxis (apache#17865)
acb535b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@haojin2 haojin2 haojin2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@haojin2 haojin2

Labels

Numpy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yijunc @mxnet-bot @haojin2